Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listen to device verification after resending email #2056

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

ignaciosantise
Copy link
Collaborator

Changes

  • fix: if the user resends the device verification email, the connectDevice promise never fulfills so it doesn't redirect to OTP screen

Steps to reproduce:

  1. Connect with email
  2. In device verification screen press "Resend email"
  3. Approve the login using the second email
  4. BUG: User is not redirected to OTP code verification view

This is a possible fix. The other possibility is to check why secure site doesn't send the @w3m-frame/CONNECT_DEVICE_SUCCESS when an email is resent

Associated Issues

N/A

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 1:04am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:04am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:04am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:04am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:04am

Copy link

vercel bot commented Mar 27, 2024

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

@tomiir tomiir merged commit c14add9 into V4 Mar 27, 2024
9 of 14 checks passed
@tomiir tomiir deleted the fix/email-device branch March 27, 2024 12:39
@tomiir tomiir mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants