-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: trim the query when searching for wallets #2167
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this should be inside of ApiController directly + test?
@tomiir Thats a good point. I think I will have to trim on the UI layer to not trigger additional requests (changed if condition). Do you think we should add trimming to the controller in addition to the current logic? |
+1 on a test for this |
Coverage Report for Coverage
File Coverage
|
When searching for wallets we would send any whitespace as well which would present us with "no wallets" screen.
Made two changes:
trimmedQuery
to ApiController instead ofquery
trimmedQuery
with previous query that is also trimmed. This will not send network calls for whitespaces