fix: vitest gh actions doesn't throw error #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactor Scripts and Workflows
Since we are using monorepo and the Vitest coverage tools don't have a proper monorepo setup, we are merging all the generated coverage files from our packages and saving them to another file with a script.
The
vitest-coverage-report-actionis using these merged coverage reports to generate comments on the PR.Note
A two different scripts like the following prevent workflow to detect issues.
"test": "npm run test; node ./scripts/coverage.jsIf the
testscript fails, when it run thecoverage.jsscript, the CI thinks that the job is OK.Upgrade Vitest
Vitest has many improvements to the GH actions in the recent versions. Upgrading it might help us to raise the error in CI.
Example: vitest-dev/vitest#5093
See recent releases: https://github.com/vitest-dev/vitest/releases
Fix
PublicStateControllertestsRecently we added the
loadingstate to the PublicStateController. The unit tests needed some updates regarding to this.*Intentionally, one of the test are still broken to test the GH Action issue.Add
vite.config.tsThe
vitest-coverage-report-actionrequires the Vite config file in the root.