fix: switch network test flakyness #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File CoverageNo changed files found. |
lukaisailovic
approved these changes
Apr 22, 2024
|
Its good that we reduced timeouts as well 👌 |
enesozturk
approved these changes
Apr 22, 2024
|
@tomiir Let's merge this to unblock other PRs. We could raise another PR if we need. |
enesozturk
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
N/A
Changes
Fixes isssue where switch network test would have flaky behavior due to the modal being closed too quickly, causing following modal openings to close prematurely.
Modified the test to better reflect user flow by expecting the screen to return to account view and show the apropiate network.
Screenshot