refactor: sync theme variables with secure site #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
svenvoskamp
reviewed
Apr 26, 2024
svenvoskamp
reviewed
Apr 26, 2024
|
Deployment failed with the following error: |
tomiir
reviewed
Apr 26, 2024
tomiir
approved these changes
Apr 26, 2024
lukaisailovic
approved these changes
Apr 26, 2024
svenvoskamp
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The secure site uses the theme variables from the web3modal version it has. But this approach is problematic. When we make changes to our theme variables over time, and if users have a web3modal version that is not the same version as the secure site's web3modal. This would create UI's with a different look inside the transaction approval screens.
This PR introduces changes to share our w3m theme variables with a secure site with a
syncThemelistener and render the UI with the same variables of w3m.See the PR on the web3modal for the required changes: https://github.com/WalletConnect/secure-web3modal/pull/122