refactor: render tooltip in root #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
svenvoskamp
requested changes
May 6, 2024
|
@svenvoskamp Totally - I wasn't quite sure about its naming but at the same time, I'm not sure if it's a reusable component in different places since we don't have any similar components. Any suggestion for a name? Taking a look danger issues right now! |
|
@svenvoskamp made a few changes danger.js checks for false errors. |
Yes we don't use it anywhere else, but I like to keep the component naming a bit more general. Maybe something like |
svenvoskamp
approved these changes
May 6, 2024
tomiir
reviewed
May 6, 2024
tomiir
approved these changes
May 6, 2024
luu-alex
added a commit
to ChainSafe/web3modal
that referenced
this pull request
May 13, 2024
* chore(lab): dogfooding button (reown-com#2206) * chore: fix typos (reown-com#2188) Signed-off-by: snoppy <[email protected]> Co-authored-by: tomiir <[email protected]> * refactor: render tooltip in root (reown-com#2210) * feat: add react-ethers 6 example (reown-com#1920) Co-authored-by: Sven <[email protected]> * refactor: swap business logic improvements (reown-com#2199) * chore: detailed canary timings (reown-com#2214) * chore: add apple app site association (reown-com#2216) * :feat add send logic (reown-com#2173) Co-authored-by: Cali93 <[email protected]> Co-authored-by: Enes <[email protected]> * fix: apple-app-site-association content type header (reown-com#2217) * feat: Sign 2.5 (reown-com#2033) Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: tomiir <[email protected]> Co-authored-by: Enes <[email protected]> * feat: Smart Account 6492 Signature Tests (reown-com#2196) * fix: sign modal not appearing when going through siwe flow (reown-com#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (reown-com#2190) Co-authored-by: Valentyn <[email protected]> * fix: missing call to SIWE `onSignOut` (reown-com#2054) Co-authored-by: Glitch <[email protected]> Co-authored-by: tomiir <[email protected]> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (reown-com#1689) Co-authored-by: tomiir <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Ilja <[email protected]> Co-authored-by: enesozturk <[email protected]> * :deprecate - injected connector (reown-com#2223) * chore: more canary timings (reown-com#2215) * chore: updates ethereum-provider to latest (reown-com#2226) * fix: add assertion for the erc20 abi json import (reown-com#2225) * update packages --------- Signed-off-by: snoppy <[email protected]> Co-authored-by: Chris Smith <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: tomiir <[email protected]> Co-authored-by: Enes <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: Luka Isailovic <[email protected]> Co-authored-by: Cali93 <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: GooxPF <[email protected]> Co-authored-by: Valentyn <[email protected]> Co-authored-by: Tiến Nguyễn Khắc <[email protected]> Co-authored-by: Nikos Rossolatos <[email protected]> Co-authored-by: Ilja <[email protected]>
luu-alex
added a commit
to ChainSafe/web3modal
that referenced
this pull request
May 16, 2024
* chore(lab): dogfooding button (reown-com#2206) * chore: fix typos (reown-com#2188) Signed-off-by: snoppy <[email protected]> Co-authored-by: tomiir <[email protected]> * refactor: render tooltip in root (reown-com#2210) * feat: add react-ethers 6 example (reown-com#1920) Co-authored-by: Sven <[email protected]> * refactor: swap business logic improvements (reown-com#2199) * chore: detailed canary timings (reown-com#2214) * chore: add apple app site association (reown-com#2216) * :feat add send logic (reown-com#2173) Co-authored-by: Cali93 <[email protected]> Co-authored-by: Enes <[email protected]> * fix: apple-app-site-association content type header (reown-com#2217) * feat: Sign 2.5 (reown-com#2033) Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: tomiir <[email protected]> Co-authored-by: Enes <[email protected]> * feat: Smart Account 6492 Signature Tests (reown-com#2196) * fix: sign modal not appearing when going through siwe flow (reown-com#2213) * Add signAndSendTransaction to Solflare, Backpack and Trust Wallet Ada… (reown-com#2190) Co-authored-by: Valentyn <[email protected]> * fix: missing call to SIWE `onSignOut` (reown-com#2054) Co-authored-by: Glitch <[email protected]> Co-authored-by: tomiir <[email protected]> * fix: dayjs locale format seconds is not working and is polluting the global dayjs locale (reown-com#1689) Co-authored-by: tomiir <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Ilja <[email protected]> Co-authored-by: enesozturk <[email protected]> * :deprecate - injected connector (reown-com#2223) * chore: more canary timings (reown-com#2215) * chore: updates ethereum-provider to latest (reown-com#2226) * fix: add assertion for the erc20 abi json import (reown-com#2225) * fix: encodes all `personal_sign` messages to hex (reown-com#2237) Co-authored-by: Gancho Radkov <[email protected]> * fix: siwe tests for 1 click auth (reown-com#2267) * feat: phantom deeplink for mobile app browsers (reown-com#2250) Co-authored-by: tomiir <[email protected]> * fix: 4.2.0 bug fixes (reown-com#2234) Co-authored-by: Enes <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: Sven <[email protected]> * chore: UI canary 10 minute timeout (reown-com#2269) * chore: bump to main 4.2.0 version (reown-com#2270) * :feat social login - 1 - UI (reown-com#2266) Co-authored-by: enesozturk <[email protected]> * :feat social login - 2 - Wallet (reown-com#2272) * :feat social login - 3 - AuthConnector (reown-com#2274) * refactor: update profile name rendering logic (reown-com#2276) * :hotfix in app support for injected and announced wallets (reown-com#2279) * refactor/theme variables and v4 ui updates (reown-com#2277) --------- Signed-off-by: snoppy <[email protected]> Co-authored-by: Chris Smith <[email protected]> Co-authored-by: Snoppy <[email protected]> Co-authored-by: tomiir <[email protected]> Co-authored-by: Enes <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: Luka Isailovic <[email protected]> Co-authored-by: Cali93 <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Gancho Radkov <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Glitch <[email protected]> Co-authored-by: Sven <[email protected]> Co-authored-by: GooxPF <[email protected]> Co-authored-by: Valentyn <[email protected]> Co-authored-by: Tiến Nguyễn Khắc <[email protected]> Co-authored-by: Nikos Rossolatos <[email protected]> Co-authored-by: Ilja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Refactor the tooltip component to render it in the root of the w3m instead of in the component of it's used. This is an approach that allow us to have more capabilities when rendering tooltips. In some situations, we might need to render a tooltip with variety children's.
wui-tooltip-select
The existing wui-tooltip-select component, originally styled as a wallet feature button, will now support a broader range of components based on the specific use case.
Why render on the root?
Overflow Handling: There are instances where the tooltip content is lengthy, causing it to overflow beyond the boundaries of the w3m component. With the previous implementation, the overflow was hidden by the w3m. Rendering at the root level resolves this issue.
Positioning and Control: Certain tooltips necessitate rendering outside the w3m component for proper positioning and control. This change allows for precise placement and management of such tooltips.
Changes
wui-tooltip-selecttowui-wallet-feature-button, since it's styling for only for wallet feature buttons on the account page.TooltipControllerto manage tooltip statew3m-tooltip-triggerto handle a variety children as a tooltip wrapperw3m-tooltipcomponent to render this on the root.