chore: Test Cases table and missing SA tests #2242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@lukaisailovic want to merge this and we update it later or will u update with new SIWE + SA test support? |
|
@lukaisailovic @tomiir I think we could merge this? |
|
@tomiir Can you please update with current testinng state? |
|
@tomiir @lukaisailovic I think we could close this. IMO it doesn't make sense to keep track of the test cases manually - this will tend to be expired very soon. Engineers shouldn't be responsible of maintaining this list. They should be responsible of adding tests for anything they developed. Since we started doing this, this table doesn't seem useful to me. Wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes