Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantom deeplinks #2281

Merged
merged 46 commits into from
Jun 10, 2024
Merged

Phantom deeplinks #2281

merged 46 commits into from
Jun 10, 2024

Conversation

phoenixVS
Copy link
Contributor

Breaking Changes

N/A

Changes

  • feat:
  • fix:
  • chore:

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jun 10, 2024 2:06pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jun 10, 2024 2:06pm

svenvoskamp
svenvoskamp requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the merge conflicts?

We only need to the changes from src/utils/defaultConfig.ts and solana/src/client.ts

@enesozturk
Copy link
Contributor

Could you please fix the merge conflicts?

We only need to the changes from src/utils/defaultConfig.ts and solana/src/client.ts

@phoenixVS

enesozturk
enesozturk reviewed Jun 10, 2024
View reviewed changes
packages/solana/src/client.ts Show resolved Hide resolved
packages/solana/src/client.ts Outdated Show resolved Hide resolved
@enesozturk
Copy link
Contributor

I will left more detailed explanation in comment

@phoenixVS Please add some sources

@enesozturk enesozturk merged commit a2b85dd into V4 Jun 10, 2024
9 checks passed
@enesozturk enesozturk deleted the phantom-deeplinks branch June 10, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melchin01 Melchin01 Melchin01 left review comments

@enesozturk enesozturk enesozturk approved these changes

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phoenixVS @enesozturk @svenvoskamp @Melchin01 @valentyn-solana