refactor: disable disconnected call for siwe if not connected #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
approved these changes
Jun 5, 2024
svenvoskamp
approved these changes
Jun 6, 2024
This is something that could be tested with integration tests, not E2E because it's a decision when to trigger SIWE actions rather than any affect to how they are working. And this change is just effecting the modal when it's in If we decide to test these kind of details, it'll bring too much workload to our E2E tests which their right place is integration tests. Maybe we could consider having them with Jest rather than Playwright |
enesozturk
deleted the
refactor/remove-disconnect-call-on-siwe-if-not-connected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When we not connected, we are still calling the client's disconnect function and if the SIWE enabled, this causing unnecessary async function and this causing the modal to be closed with a promise delay.
Also considered
We could do optimistic updates and directly close the modal and make the
signOutcalls on the background. While this might sound good, might cause some issues for certain situations