feat/chain controller #2459
Merged
feat/chain controller #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible for token list item
svenvoskamp
approved these changes
Jun 28, 2024
| @@ -84,7 +84,8 @@ export class W3mUnsupportedChainView extends LitElement { | |||
| } | |||
|
|
|||
| private networksTemplate() { | |||
| const { approvedCaipNetworkIds, requestedCaipNetworks } = NetworkController.state | |||
| const requestedCaipNetworks = NetworkController.getRequestedCaipNetworks() | |||
| const approvedCaipNetworkIds = NetworkController.state.approvedCaipNetworkIds | |||
There was a problem hiding this comment.
Why can't we use state here same as approvedCaipNetworkIds?
There was a problem hiding this comment.
If you see the getRequestedCaipNetworks() function body, we have multi-chain related conditions. Unlike the approvedCaipNetworkIds value, we need to get this value dynamically. Explained here: #2459 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
With the multi-chain, we need to refactor current controllers and implement a new controller to manage multiple adapters in a single place. With multi-chain, users will be able to customize and use different adapters at a time. Since that feature will make breaking changes to our client packages and how we are initializing & using scaffold in clients. We need to make this transition as smooth as possible so new architecture should require minimum code change on the UI components and controllers
This PR introduces
ChainControllerand necessary actions, new types, new values to our connector and network objects.ChainControlleris responsible of storing account & network states and clients.Changes