-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add chain check for including announced and injected wallets listing #2475
Merged
enesozturk
merged 88 commits into
main
from
enes/w3i-89-solana-eip-6963-flag-disable-injected-wallets-to-be-listed
Jun 28, 2024
Merged
refactor: add chain check for including announced and injected wallets listing #2475
enesozturk
merged 88 commits into
main
from
enes/w3i-89-solana-eip-6963-flag-disable-injected-wallets-to-be-listed
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible for token list item
…3m button and network button life cycle issues
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
commented
Jun 28, 2024
@@ -71,14 +78,16 @@ export class W3mConnectorList extends LitElement { | |||
const coinbase = this.connectors.find( | |||
connector => connector.id === ConstantsUtil.COINBASE_SDK_CONNECTOR_ID | |||
) | |||
const isEVM = ChainController.state.activeChain === CommonConstantsUtil.CHAIN.EVM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-chain magic
enesozturk
force-pushed
the
enes/w3i-89-solana-eip-6963-flag-disable-injected-wallets-to-be-listed
branch
from
June 28, 2024 09:37
429081c
to
d3a0123
Compare
…ected-wallets-to-be-listed
svenvoskamp
approved these changes
Jun 28, 2024
enesozturk
deleted the
enes/w3i-89-solana-eip-6963-flag-disable-injected-wallets-to-be-listed
branch
June 28, 2024 11:08
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
N/A
Changes
Associated Issues
closes #...