Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet_addEthereumChain condition #2476

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jun 28, 2024

Breaking Changes

N/A

Changes

  • fix: Updated the condition to send add chain request to only check for user rejection. It is now consistent with wagmi's connector

Associated Issues

closes #...

… the user has rejected the switch request. Its also consistent with wagmi's check
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 3, 2024 7:58am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 3, 2024 7:58am

packages/ethers/src/client.ts Outdated Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit b6f7da7 into main Jul 3, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the fix/ethers-switch-chain branch July 3, 2024 09:28
@tomiir tomiir mentioned this pull request Jul 3, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants