Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wagmi authConnector connectExternal resolving issue and enable wagmi email tests #2504

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jul 3, 2024

Description

We are disabled email tests for wagmi long ago and they were with some obvious issues. This PR includes refactors to W3mFrameProvider to handle that unresolved connectExternal issue which caused by a low level problem of wagmi.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-683
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 8, 2024 6:52am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 8, 2024 6:52am

Copy link

linear bot commented Jul 3, 2024

@enesozturk enesozturk changed the title refactor: conditionally set connector resolver variable fix: wagmi authConnector connectExternal resolving issue and enable wagmi email tests Jul 3, 2024
@enesozturk enesozturk requested review from tomiir and svenvoskamp and removed request for tomiir July 3, 2024 16:38
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Warnings
⚠️ Testing spec changed

Generated by 🚫 dangerJS against 02b7751

@enesozturk enesozturk merged commit fcfc26d into main Jul 8, 2024
9 checks passed
@enesozturk enesozturk deleted the fix/enable-wagmi-email-tests branch July 8, 2024 15:20
This was referenced Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants