-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wagmi authConnector connectExternal resolving issue and enable wagmi email tests #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
changed the title
refactor: conditionally set connector resolver variable
fix: wagmi authConnector connectExternal resolving issue and enable wagmi email tests
Jul 3, 2024
enesozturk
requested review from
tomiir and
svenvoskamp
and removed request for
tomiir
July 3, 2024 16:38
tomiir
reviewed
Jul 3, 2024
tomiir
approved these changes
Jul 3, 2024
svenvoskamp
approved these changes
Jul 3, 2024
… related improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are disabled email tests for wagmi long ago and they were with some obvious issues. This PR includes refactors to
W3mFrameProvider
to handle that unresolvedconnectExternal
issue which caused by a low level problem of wagmi.Type of change
Associated Issues
For Linear issues: Closes APKT-683
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist