Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change tooltip text for a slot #2510

Closed
wants to merge 1 commit into from
Closed

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Jul 4, 2024

Description

Changes message prop for a generic slot in order more flexibly populate the tooltip content.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

None. Internally required for https://linear.app/walletconnect/issue/APKT-433/ui-changes

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests) => Updated gallery story
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ❌ Failed (Inspect) Jul 4, 2024 1:16pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 4, 2024 1:16pm

@enesozturk
Copy link
Contributor

We switched to w3m-tooltip rather than wui-tooltip to connect it's state to TooltipController . Will this comp be used somewhere? If yes can w3m-tooltip be used instead?

@tomiir tomiir closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants