Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wagmi not showing loading indicator on email reconnection #2682

Merged

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Aug 9, 2024

Description

  • Wagmi was not properly handling loading indicators by pre-emptively setting isConnected: true while reconnecting.
  • This caused issues where the connector was apparently ready when not, failing to sign or execute other actions
  • This PR adds a check to validate the status field provided by wagmi which is more reliable than the isConnected flag.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-851

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

linear bot commented Aug 9, 2024

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Aug 9, 2024 7:48am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Aug 9, 2024 7:48am

@tomiir tomiir changed the title Fix/apkt 851 bug wagmi not showing loading indicator on email re fix: wagmi not showing loading indicator on email reconnection Aug 9, 2024
@tomiir tomiir merged commit d49161a into main Aug 9, 2024
11 checks passed
@tomiir tomiir deleted the fix/apkt-851-bug-wagmi-not-showing-loading-indicator-on-email-re branch August 9, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants