Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: export missing type defs from siwe package #2703

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Aug 15, 2024

Description

In our SIWE package, we are exporting the type definitions but this is handled manually by importing them all and exporting again. This might lead to missing some type definitions to be exported, like we did for SIWEMessageArgs. This PR introducing slight improvements to SIWE type exports.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Aug 15, 2024 7:40pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Aug 15, 2024 7:40pm

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 106.57% 2725 / 9011
🔵 Statements 106.57% 2725 / 9011
🔵 Functions 150.75% 205 / 675
🔵 Branches 213.17% 342 / 736
File CoverageNo changed files found.
Generated in workflow #5609

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-Db8-uiX4.js 1648.959 459.81
assets/index-D34n98X0.js 11.55 3.195
assets/w3m-modal-D4AdJTdz.js 6.856 2.476
assets/index-CsNp9EU3.js 112.437 34.331
assets/index-CywL2Zf_.js 9.39 3.339
assets/hooks.module-CktZipCk.js 77.565 26.51
assets/ccip-r9Z6qsTl.js 3.029 1.379
assets/index-ClN6YrIE.js 161.649 59.485
assets/index-Bo60jI0N.js 102.257 29.12
assets/index-ChT9XpaH.js 304.097 87.218
index.html 0.329 0.237
Total Size 2438.118 707.1

Base Size

Name Size (kb) Gzip (kb)
assets/index-Db8-uiX4.js 1648.959 459.81
assets/ccip-r9Z6qsTl.js 3.029 1.379
assets/index-D34n98X0.js 11.55 3.195
assets/index-CywL2Zf_.js 9.39 3.339
assets/w3m-modal-D4AdJTdz.js 6.856 2.476
assets/index-CsNp9EU3.js 112.437 34.331
assets/index-Bo60jI0N.js 102.257 29.12
assets/hooks.module-CktZipCk.js 77.565 26.51
assets/index-ClN6YrIE.js 161.649 59.485
assets/index-ChT9XpaH.js 304.097 87.218
index.html 0.329 0.237
Total Size 2438.118 707.1

@enesozturk enesozturk merged commit 27b4a3d into main Aug 16, 2024
12 checks passed
@enesozturk enesozturk deleted the fix/siwe-missing-type-defs branch August 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants