fix: ethers5 adapter import in exports #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
tomiir
reviewed
Aug 27, 2024
| @@ -1,6 +1,7 @@ | |||
| import '@web3modal/polyfills' | |||
|
|
|||
| export { EVMEthersClient } from './client.js' | |||
| export * from '@web3modal/scaffold-utils/ethers' | |||
There was a problem hiding this comment.
Yes, we are connecting to the EthersStoreUtil from the backwards compat packages' custom hooks, see. To make the ethers and base package use the same proxy object (state), the @web3modal/scaffold-utils/ethers needed to be exported from the adapter. Otherwise throwing this pmndrs/valtio#706 error.
|
Email flow seems broken from preview 🤔 |
Seems like it's not awaiting the connection after OTP. It's closing the modal, but after a few seconds it's getting connected. There should be a state management detail off |
tomiir
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the exports of the
ethers5, we are importingethersadapter which is wrong and should beethers5.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist