Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement actions using userOpBuilder service instead of permissionless.js #2758

Merged
merged 23 commits into from
Sep 3, 2024

Conversation

KannuSingh
Copy link
Collaborator

@KannuSingh KannuSingh commented Aug 28, 2024

Description

  • refactored permissions implementations
  • using UserOpBuilder service instead of UserOpBuilder Contract for building userOperation.
  • removed permissionless.js dependency

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

-replace useUserOpBuilder hook with UserOpBuilderUtils
-replace useWalletConnectCosigner hook with WalletConnectCosignerUtils
- merged useERC7715PermissionsAsync and useERC7715PermissionsSync into new useERC7715Permissions hook
- added usePasskey and useLocalEcdsaKey hook and it context for sync and aSync flow
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 3, 2024 10:00pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 3, 2024 10:00pm

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 86.76% 3189 / 13453
🔵 Statements 86.76% 3189 / 13453
🔵 Functions 161.44% 236 / 723
🔵 Branches 215.2% 431 / 848
File CoverageNo changed files found.
Generated in workflow #5933

Copy link
Contributor

github-actions bot commented Aug 28, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 3.268 1.355

Current Size

Name Size (kb) Gzip (kb)
assets/index-CEApWQLP.js 1475.014 417.536
assets/noble-curves.js 31.941 12.78
assets/2.19.6_typescript.js 2.789 1.326
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.114
assets/index3.js 304.389 87.281
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.509
assets/index5.js 9.415 3.342
assets/hooks.module.js 74.776 25.685
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.238
Total Size 2571.952 756.729

Base Size

Name Size (kb) Gzip (kb)
assets/index-AyQbJiHp.js 1475.023 417.543
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.325
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.28
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.509
assets/index5.js 12.674 4.696
assets/hooks.module.js 74.776 25.684
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.236
Total Size 2575.22 758.084

- removed permissions usage method from useErc7715Permissions hook
- added executeActionsWithPasskeyAndCosignerPermissions and executeActionsWithECDSAAndCosignerPermissions to ERC7715Utils
- removed separate methods for requestPermissionsSync and requestPermissionsAsync to a single method requestPermissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants