Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing chainId param for transactions request #2779

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Sep 2, 2024

Description

Adds missing chainId param for BlockchainApiController transactions request.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 2, 2024 2:00pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 2, 2024 2:00pm

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 87.52% 3186 / 13174
🔵 Statements 87.52% 3186 / 13174
🔵 Functions 161.44% 236 / 723
🔵 Branches 214.99999999999997% 428 / 845
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/controllers/BlockchainApiController.ts 29.47% 100% 0% 29.47% 131-138, 141-160, 163-184, 187-194, 197-208, 211, 213-226, 229, 231-243, 246-268, 271-276, 278-292, 295, 297-310, 313-319, 322-329, 332-338, 341-353, 356-375, 377-378, 381-382, 385-390, 392-396, 399-411, 413-414, 416-425, 428-430
packages/core/src/controllers/TransactionsController.ts 81.6% 87.5% 75% 81.6% 42-43, 46-47, 53-54, 91-107
packages/core/src/utils/TypeUtil.ts 100% 100% 100% 100%
Generated in workflow #5899

Copy link
Contributor

github-actions bot commented Sep 2, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CorWxYFQ.js 1473.445 417.232
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.325
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.281
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.509
assets/index5.js 12.674 4.695
assets/hooks.module.js 74.776 25.685
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.236
Total Size 2573.642 757.774

Base Size

Name Size (kb) Gzip (kb)
assets/index-CorWxYFQ.js 1473.445 417.232
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.325
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.281
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.509
assets/index5.js 12.674 4.695
assets/hooks.module.js 74.776 25.685
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.236
Total Size 2573.642 757.774

@zoruka zoruka merged commit 5869107 into main Sep 2, 2024
14 checks passed
@zoruka zoruka deleted the fix/blockchain-api-transactions-chainid branch September 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants