Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: social login shows undefined #2783

Merged
merged 8 commits into from
Sep 4, 2024
Merged

fix: social login shows undefined #2783

merged 8 commits into from
Sep 4, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Sep 2, 2024

Description

If providing empty auth.socials array it'll display "Continue with undefined..." text

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-986

Showcase (Optional)

Before

socials-bug

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

linear bot commented Sep 2, 2024

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 4, 2024 7:52am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 4, 2024 7:52am

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 86.76% 3189 / 13453
🔵 Statements 86.76% 3189 / 13453
🔵 Functions 161.44% 236 / 723
🔵 Branches 215.12999999999997% 430 / 847
File CoverageNo changed files found.
Generated in workflow #5948

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Warnings
⚠️ Changes were made to one or more package.json(s), but not to pnpm-lock.yaml

Generated by 🚫 dangerJS against f36d4a7

Copy link
Contributor

github-actions bot commented Sep 2, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-giy-ijYL.js 1475.044 417.548
assets/noble-curves.js 31.941 12.779
assets/2.19.6_typescript.js 2.789 1.325
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.28
assets/walletconnect-ethereum-provider.js 278.197 80.093
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.507
assets/index5.js 9.415 3.343
assets/hooks.module.js 74.776 25.685
assets/walletconnect-modal-ui.js 112.43 34.327
index.html 0.329 0.234
Total Size 2571.982 756.73

Base Size

Name Size (kb) Gzip (kb)
assets/index-giy-ijYL.js 1475.044 417.548
assets/noble-curves.js 31.941 12.779
assets/2.19.6_typescript.js 2.789 1.325
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.28
assets/walletconnect-ethereum-provider.js 278.197 80.093
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.507
assets/index5.js 9.415 3.343
assets/hooks.module.js 74.776 25.685
assets/walletconnect-modal-ui.js 112.43 34.327
index.html 0.329 0.234
Total Size 2571.982 756.73

Copy link
Contributor

@zoruka zoruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need this tests also for solana?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants