-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: social login shows undefined
#2783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File CoverageNo changed files found. |
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
tomiir
reviewed
Sep 2, 2024
zoruka
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need this tests also for solana?
enesozturk
reviewed
Sep 2, 2024
zoruka
approved these changes
Sep 3, 2024
tomiir
approved these changes
Sep 3, 2024
enesozturk
approved these changes
Sep 3, 2024
enesozturk
force-pushed
the
fix/socials-bug
branch
from
September 4, 2024 07:59
d65193c
to
f36d4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If providing empty
auth.socials
array it'll display "Continue with undefined..." textType of change
Associated Issues
For Linear issues: Closes APKT-986
Showcase (Optional)
Before
Checklist