chore: test ethers verify API + AppKit in iframe verify test case #2831
+375
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File CoverageNo changed files found. |
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
…/test-ethers-verify
|
chris13524
changed the title
tomiir
approved these changes
Nov 13, 2024
| @@ -30,6 +30,18 @@ export const testM = timingFixture.extend<ModalFixture>({ | |||
| await use(modalPage) | |||
| } | |||
| }) | |||
| export const testMEthers = timingFixture.extend<ModalFixture>({ | |||
There was a problem hiding this comment.
How is this different fromcthe default testM? / why does it need a special case?
added 2 commits
November 13, 2024 10:30
…/test-ethers-verify
… specific projects only
tomiir
reviewed
Nov 13, 2024
| object-src 'none'; | ||
| base-uri 'self'; | ||
| form-action 'self'; | ||
| frame-ancestors 'none'; | ||
| frame-ancestors ${verifyApiNestedIframesTestOuterDomain}; |
There was a problem hiding this comment.
do we need to conditionally add this on test env?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing test coverage for Verify API on the Ethers SDK.
Also adds test coverage for https://github.com/WalletConnect/cloud-app/pull/1509
Remaining work:
Fixes APKT-1445
Type of change