Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to account chains to get session chains #2855

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Sep 16, 2024

Description

This PR is adding a fallback for accounts param when connecting to Solana with WalletConnectProvider and the session chains param is not available.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 16, 2024 2:23pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 16, 2024 2:23pm

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 86.7% 3273 / 13647
🔵 Statements 86.7% 3273 / 13647
🔵 Functions 162.48000000000002% 240 / 729
🔵 Branches 215.33% 445 / 869
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/base/adapters/solana/web3js/providers/WalletConnectProvider.ts 87.15% 84.09% 87.5% 87.15% 67, 69-71, 73-74, 84, 169-174, 176-177, 207, 223-224, 252-254, 256, 259, 263-265, 267, 270
Generated in workflow #6092

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-Wu8TCg2T.js 1607.067 465.955
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index.js 9.517 3.191
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.281
assets/walletconnect-ethereum-provider.js 454.329 141.409
assets/index4.js 11.601 3.206
assets/w3m-modal.js 6.988 2.504
assets/index5.js 12.673 4.696
assets/hooks.module.js 74.437 25.585
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.237
Total Size 2730.736 811.613

Base Size

Name Size (kb) Gzip (kb)
assets/index-Wu8TCg2T.js 1607.067 465.955
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index.js 9.517 3.191
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.281
assets/walletconnect-ethereum-provider.js 454.329 141.409
assets/index4.js 11.601 3.206
assets/w3m-modal.js 6.988 2.504
assets/index5.js 12.673 4.696
assets/hooks.module.js 74.437 25.585
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.237
Total Size 2730.736 811.613

@zoruka zoruka merged commit 9a51638 into main Sep 16, 2024
15 checks passed
@zoruka zoruka deleted the fix/solana-wcprovider-session-chains branch September 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants