Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change SafeLocalStorage key type #2868

Closed
wants to merge 3 commits into from

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Sep 18, 2024

Description

This PR is changing the type of SafeLocalStorage @w3m/active_caip_network to the object type, so we don't need to stringfy or parse outside of the util function.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 18, 2024 3:25pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 18, 2024 3:25pm

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: 6b928ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 242.17% 4166 / 10429
🔵 Statements 242.17% 4166 / 10429
🔵 Functions 268.27000000000004% 320 / 802
🔵 Branches 309.79999999999995% 570 / 1041
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/src/universal-adapter/client.ts 55.24% 47.16% 50% 55.24% 102-103, 138-139, 142, 147-148, 150-152, 161-164, 166-168, 170-172, 174-179, 181, 183-192, 194, 196-199, 201-206, 208, 210, 212-215, 229-231, 240-242, 244-246, 248-251, 253-254, 280-281, 299-304, 308-313, 323, 325-328, 334-342, 344, 346-347, 364-365, 367-372, 399-403, 407-412, 453-456, 458-459, 461-463, 466-469, 473-475, 477-497, 535-540, 543-546, 550-551, 553-556, 558-560, 562-564, 566-573, 576-578, 580-595
packages/common/src/utils/SafeLocalStorage.ts 100% 100% 100% 100%
packages/core/src/controllers/ChainController.ts 67.94% 52% 76.47% 67.94% 73-77, 80-84, 86-87, 89-97, 103-104, 132, 134-146, 150-158, 170-171, 194-195, 237-239, 241-243, 245-246, 248-252, 261, 263-264, 296-299, 311-313, 315-316, 325-326, 345-347, 349-350, 353-354, 359-360, 363-364, 376-377, 380-381, 386-387, 399-400, 405-406, 412, 414-419, 421-422, 428-429
Generated in workflow #6132

Copy link
Contributor

github-actions bot commented Sep 18, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-BuC9XD2e.js 1870.051 533.701
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.371 2.602
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2414.77 698.995

Base Size

Name Size (kb) Gzip (kb)
assets/index-BuC9XD2e.js 1870.051 533.701
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.371 2.602
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.237
Total Size 2414.77 698.995

@zoruka
Copy link
Contributor Author

zoruka commented Sep 18, 2024

closing in favor of #2861

@zoruka zoruka closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant