Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sdkVersion header optional #2897

Merged
merged 2 commits into from
Sep 21, 2024
Merged

chore: make sdkVersion header optional #2897

merged 2 commits into from
Sep 21, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 21, 2024

Description

Makes sdkVersion value optional

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • [] Code in this PR is covered by automated tests (Unit tests, E2E tests)
    Trying to get a lab version with 5.1.8 running to test this but could take a bit

  • My changes generate no new warnings

  • I have reviewed my own code

  • I have filled out all required sections

  • I have tested my changes on the preview link

  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 21, 2024

🦋 Changeset detected

Latest commit: cfaeca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-wallet Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 21, 2024 5:16pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 21, 2024 5:16pm

Copy link
Contributor

github-actions bot commented Sep 21, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 239.76% 4139 / 10418
🔵 Statements 239.76% 4139 / 10418
🔵 Functions 269.68% 322 / 805
🔵 Branches 310.23% 565 / 1042
File CoverageNo changed files found.
Generated in workflow #6239

Copy link
Contributor

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CK3APbEV.js 1867.199 532.987
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.239
Total Size 2411.944 698.299

Base Size

Name Size (kb) Gzip (kb)
assets/index-CK3APbEV.js 1867.199 532.987
assets/index.js 9.63 3.161
assets/index2.js 11.572 3.199
assets/w3m-modal.js 7.397 2.615
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.328
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.443 25.59
index.html 0.329 0.239
Total Size 2411.944 698.299

@tomiir tomiir merged commit fb20e46 into main Sep 21, 2024
17 checks passed
@tomiir tomiir deleted the fix/sdkVersionType branch September 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants