Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements in siwx flow #3179

Merged
merged 14 commits into from
Nov 7, 2024
Merged

feat: improvements in siwx flow #3179

merged 14 commits into from
Nov 7, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Oct 31, 2024

Description

  • Add SIWX handler for account switch
  • Clean up SIWX initialization
  • Fixes for multichain switches

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1320
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 35d47b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-siwx Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery ✅ Ready (Inspect) Visit Preview Nov 7, 2024 1:39pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:39pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:39pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:39pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:39pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:39pm

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 340.11% 4495 / 18779
🔵 Statements 340.11% 4495 / 18779
🔵 Functions 375.89% 371 / 1088
🔵 Branches 465.71000000000004% 682 / 1387
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/universal-adapter/client.ts 49.2% 46.77% 47.36% 49.2% 111-115, 133-134, 137, 142-143, 145-147, 159-163, 165-218, 231-233, 242-279, 295-311, 314-320, 322-328, 338-343, 346-350, 373-378, 382-387, 394-416, 422, 424-427, 453-474, 491-499, 527-528, 530, 535-536, 555-560, 571-580, 583-586, 590-618, 657-661, 666-669, 686-687, 699-724, 741-748
packages/core/src/controllers/ConnectionController.ts 35.43% 76.92% 23.07% 35.43% 82-86, 93-94, 100-130, 151-153, 156-172, 175-176, 179-180, 183-184, 187-188, 191-192, 195-196, 199-200, 203-204, 207-208, 211-212, 229-230, 233-235, 238-239, 242-243, 246-247, 255-261, 266-267, 276-327
packages/scaffold-ui/src/modal/w3m-modal/index.ts 0% 0% 0% 0% 1-272
Generated in workflow #7254 for commit 35d47b9 by the Vitest Coverage Report Action

@zoruka zoruka marked this pull request as ready for review November 1, 2024 17:49
Copy link

linear bot commented Nov 1, 2024

@tomiir tomiir merged commit ffb30d3 into main Nov 7, 2024
19 checks passed
@tomiir tomiir deleted the feat/siwx-flow-improvements branch November 7, 2024 19:36
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants