Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: siwe to siwx migration #3194
base: main
Are you sure you want to change the base?
chore: siwe to siwx migration #3194
Changes from 34 commits
4559f59
4938fdb
2ce57a2
07a6605
63c34ef
6e4cbed
2e01a07
04a1c90
3190dcf
36598e9
edb0fe5
b72b68d
fc061f2
7bec91c
be32fb1
192067b
b40dc5f
92326a5
5791611
adce84e
1f216f1
c4fea48
f2fcb2c
dddf0bd
28e21c5
0fb0ca3
d833588
61431ca
499562d
11b47e6
5ce726d
be5f4fe
b1d59a1
bcab8ea
7677a16
b6c3ad5
03139c7
50f156e
30e28f9
54c5552
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't like nested inline definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also what happens with [] chains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the more I think about it, this method should not exist on the adapters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what to do about this 😞 if we don't do it, it will break the signature for solana