Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): removing the trailing slash from the RPC url #467

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

geekbrother
Copy link
Contributor

Description

Removing the trailing slash from the RPC URL from the manual workflow call for the Providers.
The trailing slash causes the test to fail if a user is not modifying it. It's better to fix it to be valid by default.

How Has This Been Tested?

With trailing slash - Fail
Without trailing slash - Success

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 15, 2024
@geekbrother geekbrother marked this pull request as ready for review January 15, 2024 10:09
@geekbrother geekbrother requested a review from xav as a code owner January 15, 2024 10:09
@geekbrother geekbrother merged commit c2184ba into master Jan 15, 2024
7 checks passed
@geekbrother geekbrother deleted the fix/rpc_url_slash branch January 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants