feat(providers): updating Pokt endpoint #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
fix/new_pokt_endpoints
branch
from
70d7f37
to
dff81d3
Compare
geekbrother
commented
Jan 17, 2024
| @@ -13,6 +13,7 @@ Chain name with associated `chainId` query param to use. | |||
| - Arbitrum Goerli (`eip155:421613`) | |||
| - Polygon (`eip155:137`) | |||
| - Polygon Mumbai (`eip155:80001`) | |||
| - Polygon Zkevm (`eip155:1101`) | |||
There was a problem hiding this comment.
We forgot to add it to the list despite we were supporting it for at least 7 months.
geekbrother
force-pushed
the
fix/new_pokt_endpoints
branch
from
dff81d3
to
23b7184
Compare
geekbrother
commented
Jan 17, 2024
| // Weight::new(Priority::Normal).unwrap(), | ||
| // ), | ||
| // ), | ||
| // AVAX mainnet |
There was a problem hiding this comment.
I don't know why this was commented, but we are supporting eip155:43114 in other providers as well as Grove/Pokt supports it.
geekbrother
commented
Jan 17, 2024
| @@ -76,10 +76,6 @@ fn default_supported_chains() -> HashMap<String, (String, Weight)> { | |||
| "eip155:5".into(), | |||
| ("eth-goerli".into(), Weight::new(Priority::Normal).unwrap()), | |||
| ), | |||
| ( | |||
There was a problem hiding this comment.
Is not supported by Pokt/Grove anymore https://docs.grove.city/guides/getting-started/supported-blockchains.
We don't need to remove it from the supported list because it's supported by Infura.
geekbrother
commented
Jan 17, 2024
| // Binance mainnet | ||
| check_if_rpc_is_responding_correctly_for_supported_chain(ctx, "eip155:56", "0x38").await; | ||
|
|
||
| // Gnosis | ||
| check_if_rpc_is_responding_correctly_for_supported_chain(ctx, "eip155:100", "0x64").await | ||
| // Ethereum |
There was a problem hiding this comment.
Adding missing tests for supported chains.
arein
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Pokt provider announced changing the endpoint:
This PR implements changes according to the new provider changes and adds minor fixes.
Resolves #461
How Has This Been Tested?
Functional (integration) tests for the provider and used chains.
Due Diligence