fix(CA): fixing the nonce calculation, decreasing gas estimate, transactions chain ID fix #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
reviewed
Nov 5, 2024
| @@ -19,8 +19,8 @@ describe('Chain abstraction orchestrator', () => { | |||
| const amount_multiplier = 5; // +5% topup | |||
| // How much needs to be topped up | |||
| const amount_to_topup = (amount_to_send - usdc_funds_on_optimism) * (100 + amount_multiplier) / 100; | |||
| // Default gas esimation is default with 4x increase | |||
| const gas_estimate = "0xa69ac"; | |||
| // Default gas esimation is default with 2x increase | |||
There was a problem hiding this comment.
Why are we hardcoding this 2x thing? Don't we know the actual amount with eth_estimateGas?
There was a problem hiding this comment.
That's because we hardcoded the x2 here, will do this followup now, but we need to ship this asap.
chris13524
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues:
nonce is too higherror,How Has This Been Tested?
Due Diligence