Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web_socket_channel dependency #10

Open
ahmed-tarek-salem opened this issue Oct 8, 2024 · 2 comments
Open

Update web_socket_channel dependency #10

ahmed-tarek-salem opened this issue Oct 8, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file walletkit WalletKit related issue

Comments

@ahmed-tarek-salem
Copy link

ahmed-tarek-salem commented Oct 8, 2024

Is your feature request related to a problem? Please describe.
I'm experiencing a dependency conflict in my Flutter project when trying to use reown_walletkit ^1.0.0 alongside share_plus ^10.0.2. The conflict arises due to incompatible versions of the web package required by web_socket_channel from reown_walletkit and share_plus.

Error:

Resolving dependencies...
Because no versions of share_plus match >10.0.2 <11.0.0 and share_plus 10.0.2 depends on web ^1.0.0, share_plus ^10.0.2 requires web ^1.0.0.
And because web_socket_channel >=2.4.4 <3.0.1 depends on web ^0.5.0, share_plus ^10.0.2 is incompatible with web_socket_channel >=2.4.4 <3.0.1.
And because every version of reown_walletkit depends on reown_core ^1.0.0 which depends on web_socket_channel ^2.4.4, share_plus ^10.0.2 is incompatible with reown_walletkit.
So, because my_project depends on both share_plus ^10.0.2 and reown_walletkit ^1.0.0, version solving failed.

Describe the solution you'd like:
It would be helpful to update the web_socket_channel dependency to >=2.4.4 <3.0.1 or any version that supports web: ^1.0.0, which resolves this conflict.

Describe alternatives you've considered:
For now, I am using a dependency override:

dependency_overrides:
  web_socket_channel: ^3.0.0

However, this might lead to runtime issues, so a proper update would be preferred.

@quetool
Copy link
Member

quetool commented Oct 11, 2024

Hello @ahmed-tarek-salem ! Thanks for opening, using dependency override it's the right solution right now IMHO. I'll be upgrading all dependencies ASAP anyway.

@quetool quetool added the dependencies Pull requests that update a dependency file label Oct 11, 2024
@quetool quetool self-assigned this Oct 11, 2024
@quetool
Copy link
Member

quetool commented Oct 11, 2024

@ahmed-tarek-salem major dependency upgrades are going to be held during our tech debt week, which should happen before EOY

@quetool quetool added the walletkit WalletKit related issue label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file walletkit WalletKit related issue
Projects
None yet
Development

No branches or pull requests

2 participants