Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package_info_plus dependency #9

Open
michalcickan opened this issue Oct 8, 2024 · 5 comments
Open

Update package_info_plus dependency #9

michalcickan opened this issue Oct 8, 2024 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file walletkit WalletKit related issue

Comments

@michalcickan
Copy link

Is your feature request related to a problem? Please describe.
I have the newest package_info_plus version, and reown_core still depends on the older version, 7.0.0. Now the error looks like this:

Because no versions of reown_walletkit match >1.0.1 <2.0.0 and reown_walletkit 1.0.1 depends on reown_core ^1.0.0, reown_walletkit ^1.0.1 requires reown_core ^1.0.0.
Because reown_core 1.0.0 depends on package_info_plus ^7.0.0 and no versions of reown_core match >1.0.0 <2.0.0, reown_core ^1.0.0 requires package_info_plus ^7.0.0.
Thus, reown_walletkit ^1.0.1 requires package_info_plus ^7.0.0.

Describe the solution you'd like
Please update dependency to ^8.0.0

Describe alternatives you've considered
Now, I use dependency override, what is not a great solution.

dependency_overrides:
  package_info_plus: ^8.0.2
@michalcickan michalcickan changed the title Update package_inf_plus dependency Update package_info_plus dependency Oct 8, 2024
@quetool
Copy link
Member

quetool commented Oct 11, 2024

Hello @michalcickan! Thanks for opening, using dependency override it's the right solution right now IMHO. I'll be upgrading all dependencies ASAP anyway.

@quetool quetool self-assigned this Oct 11, 2024
@quetool quetool added the dependencies Pull requests that update a dependency file label Oct 11, 2024
@quetool
Copy link
Member

quetool commented Oct 11, 2024

@michalcickan major dependency upgrades are going to be held during our tech debt week, which should happen before EOY

@quetool quetool added appkit AppKit related issue walletkit WalletKit related issue and removed appkit AppKit related issue labels Oct 16, 2024
@ahmed-tarek-salem
Copy link

Hi @michalcickan

For me, I updated the package_info_plus to the latest version (8.1.0).
And it works fine.

@AlexV525
Copy link
Contributor

@quetool Most of the fields are the same from v5 to v8. You can write >=5.0.0 <9.0.0 to allow these versions.

@quetool
Copy link
Member

quetool commented Oct 23, 2024

Hello @michalcickan @ahmed-tarek-salem @AlexV525
This should be already fixed in reown_walletkit: ^1.0.2, could you try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file walletkit WalletKit related issue
Projects
None yet
Development

No branches or pull requests

4 participants