Feat/cocoapods #41
Merged
Feat/cocoapods #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
force-pushed
the
feat/cocoapods
branch
3 times, most recently
from
25902d9
to
d660f4a
Compare
chris13524
reviewed
Oct 16, 2024
chris13524
reviewed
Oct 16, 2024
| s.name = 'YttriumWrapper' | ||
| s.version = '0.0.0' | ||
| s.summary = '4337 implementation' | ||
| s.description = '4337 implementation ' |
There was a problem hiding this comment.
Suggested change
| s.description = '4337 implementation ' | |
| s.description = '4337 implementation' |
chris13524
reviewed
Oct 16, 2024
|
|
||
| extension Config { | ||
|
|
||
| public static func local() -> Self { | ||
| Config(endpoints: .local()) | ||
| } | ||
|
|
||
| static func pimlico() throws -> Self { |
There was a problem hiding this comment.
Are this config logic getting moved elsewhere?
There was a problem hiding this comment.
it wasn't used at all, we are injecting bundlerUrl from swift on init
chris13524
approved these changes
Oct 16, 2024
Co-authored-by: Chris Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.