feat: ERC-6492 creation #44
Conversation
chris13524
force-pushed
the
feat/erc6492-creation
branch
from
92579ed
to
8110fbc
Compare
…/erc6492-creation
chris13524
force-pushed
the
feat/erc6492-creation
branch
from
8110fbc
to
06c9ba5
Compare
chris13524
force-pushed
the
feat/erc6492-creation
branch
from
06c9ba5
to
c93caf9
Compare
…/erc6492-creation
chris13524
force-pushed
the
feat/erc6492-creation
branch
from
e5ab7ce
to
5591abb
Compare
| .await | ||
| } | ||
|
|
||
| pub async fn finalize_sign_message( |
There was a problem hiding this comment.
Why do we need 3 steps to create a signature?
There was a problem hiding this comment.
Need 2 signatures unfortunately, 3rd step is to accept the second signature
| @@ -131,8 +140,67 @@ impl AccountClient { | |||
| .await | |||
| } | |||
|
|
|||
| pub async fn sign_message(&self, message: String) -> eyre::Result<String> { | |||
| todo!("Implement sign_message: {}", message) | |||
| pub fn prepare_sign_message( | |||
There was a problem hiding this comment.
Kotlin, It would copy these methods to account_client in kotlin-ffi. With some tweaks, it should work
| _message_hash: String, | ||
| ) -> Result<FFIPreparedSignature, FFIError>; | ||
|
|
||
| pub async fn do_sign_message( |
There was a problem hiding this comment.
just thinking what do we need this method for?
There was a problem hiding this comment.
I think we addressed this
There was a problem hiding this comment.
yep, maybe we can just add the 3rd method bindings
There was a problem hiding this comment.
That's finalize_sign_message()
There was a problem hiding this comment.
It's in crates/ffi/src/account_client.rs
I didn't add to Swift
This implements 6492 signature creation for deployed and non-deployed cases.
Remaining work:
Resolves RES-97