Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Kotlin CI #45

Merged
merged 38 commits into from
Oct 28, 2024
Merged

feat: Kotlin CI #45

merged 38 commits into from
Oct 28, 2024

Conversation

jakubuid
Copy link
Contributor

@jakubuid jakubuid commented Oct 17, 2024 •
edited
Loading

  • CI for Kotlin bindings
  • Binaries and Bindings are build/generated on the CI and store within the GH release

jakubuid and others added 30 commits October 15, 2024 09:16
@jakubuid
Build binaries without UDL file
7c1b25c
@jakubuid
Generate bindings out of promacros
5339f20
@jakubuid
Clean up
ae1a095
@jakubuid
Add cli feature to uniffi
38bd24d
@jakubuid
Clean up
e8ae419
@chris13524
chore: test building w/o all features (#43)
d8f21b7
@jakubuid @chris13524
Update crates/yttrium/src/lib.rs
cdcfcdd 
Co-authored-by: Chris Smith <[email protected]>
@jakubuid @chris13524
Update crates/yttrium/src/account_client.rs
92670ff 
Co-authored-by: Chris Smith <[email protected]>
@jakubuid @chris13524
Update crates/yttrium/src/config.rs
846f63c 
Co-authored-by: Chris Smith <[email protected]>
@jakubuid @chris13524
Update crates/yttrium/src/config.rs
4ca465c 
Co-authored-by: Chris Smith <[email protected]>
@jakubuid @chris13524
Update crates/yttrium/src/config.rs
5969775 
Co-authored-by: Chris Smith <[email protected]>
fix: CI check
9a0f061
fix: build
a127e7f
@jakubuid
Formatting
6fa5b11
@jakubuid
Add kotlin release workflow
131779b
@jakubuid
Add trigger for tests
5eae316
@jakubuid
Update
8c9f1d7
@jakubuid
Fix invalid file
172809f
@jakubuid
Merge branch 'main' of https://github.com/WalletConnect/yttrium into …
895a81a 
…kotlin_ci
@jakubuid
Update action version
88c8987
@jakubuid
Change action for Android
30a5ead
@jakubuid
Update java versions
d749f23
@jakubuid
Set up java first
5352689
@jakubuid
Install cargo ndk
b606a14
@jakubuid
Update
2b54672
@jakubuid
Fix path to binary when generating bindings
579fc18
@jakubuid
Fix artifacts paths
6cf77a0
@jakubuid
Create a separate job for a release
42e3c62
@jakubuid
Change job names
81826bd
@jakubuid
FIX FILE
34abefb
@jakubuid jakubuid marked this pull request as ready for review October 18, 2024 12:11
chris13524
chris13524 reviewed Oct 18, 2024
View reviewed changes
.github/workflows/release-kotlin.yml
name: artifacts
path: yttrium/

release-kotlin-artifacts:
Copy link
Member

@chris13524 chris13524 Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 2 jobs instead of 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it targets two android architectures built on two jobs and we want to create a one release when these two jobs are finished

@jakubuid jakubuid merged commit 336792b into main Oct 28, 2024
3 checks passed
@jakubuid jakubuid deleted the kotlin_ci branch October 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@chris13524 chris13524 chris13524 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubuid @chris13524 @llbartekll