Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Promise.race related memory leaks in combinator functions. #66

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Fix Promise.race related memory leaks in combinator functions. #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a06867a
fix deps in package.json
brainkim Sep 2, 2020
03f4560
avoid Promise.race in combinators
brainkim Sep 2, 2020
1ba63ea
add some type testing
brainkim Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pubsub/src/__tests__/pubsub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ describe("InMemoryPubSub", () => {
test("close", () => {
const pubsub = new InMemoryPubSub();
pubsub.close();
expect(1).toEqual(1);
});
});
8 changes: 3 additions & 5 deletions packages/repeater/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"name": "@repeaterjs/repeater",
"version": "3.0.3",
"description": "The missing constructor function for creating safe async iterators",
"type": "module",
"repository": {
"type": "git",
"url": "https://github.com/repeaterjs/repeater",
Expand All @@ -15,6 +14,7 @@
"*.js.map",
"cjs"
],
"type": "module",
"main": "cjs/repeater.js",
"module": "repeater.js",
"types": "repeater.d.ts",
Expand All @@ -26,10 +26,6 @@
"prepublishOnly": "yarn run test && yarn run build",
"test": "jest --config ./jest.config.cjs --rootDir ./ --color"
},
"dependencies": {
"magic-string": "^0.25.7",
"ts-transform-import-path-rewrite": "^0.2.1"
},
"devDependencies": {
"@types/jest": "^26.0.7",
"@typescript-eslint/eslint-plugin": "^3.7.1",
Expand All @@ -40,11 +36,13 @@
"eslint-plugin-jest": "^23.20.0",
"eslint-plugin-prettier": "^3.1.4",
"jest": "^26.2.1",
"magic-string": "^0.25.7",
"prettier": "^2.0.5",
"rollup": "^2.23.0",
"rollup-plugin-typescript2": "^0.27.1",
"shx": "^0.3.2",
"ts-jest": "^26.1.4",
"ts-transform-import-path-rewrite": "^0.2.1",
"typescript": "^3.9.7"
},
"publishConfig": {
Expand Down
98 changes: 98 additions & 0 deletions packages/repeater/src/__tests__/combinators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,3 +1048,101 @@ describe("combinators", () => {
});
});
});

// Testing type inference.
function _types() {
/* eslint-disable */
let iteration1: Promise<IteratorResult<number>>;
let iteration2: Promise<IteratorResult<string>>;
let iteration3: Promise<IteratorResult<number | string>>;
let iteration4: Promise<IteratorResult<number | string | null>>;

const repeater1 = new Repeater<number, number>((push, stop) => {
push(1);
return -1;
});
const repeater2 = new Repeater<string, string>((push, stop) => {
push("hello");
return "goodbye";
});

const race1 = Repeater.race([Promise.resolve(null), repeater1]);
iteration1 = race1.next();
// @ts-expect-error
iteration2 = race1.next();
iteration3 = race1.next();
iteration4 = race1.next();

const race2 = Repeater.race([Promise.resolve(null), repeater1, repeater2]);

// @ts-expect-error
iteration1 = race2.next();
// @ts-expect-error
iteration2 = race2.next();
iteration3 = race2.next();
iteration4 = race1.next();

const merge1 = Repeater.merge([Promise.resolve("hello"), Promise.resolve(1)]);
// @ts-expect-error
iteration1 = merge1.next();
// @ts-expect-error
iteration2 = merge1.next();
iteration3 = merge1.next();
iteration4 = merge1.next();

const merge2 = Repeater.merge([Promise.resolve(null), repeater1, repeater2]);

// @ts-expect-error
iteration1 = merge2.next();
// @ts-expect-error
iteration2 = merge2.next();
// @ts-expect-error
iteration3 = merge2.next();
iteration4 = merge2.next();

let iteration5: Promise<IteratorResult<[number]>>;
let iteration6: Promise<IteratorResult<[string]>>;
let iteration7: Promise<IteratorResult<[number, string]>>;
let iteration8: Promise<IteratorResult<[null, number, string]>>;

const zip1 = Repeater.zip([repeater1, repeater2]);
// @ts-expect-error
iteration5 = zip1.next();
// @ts-expect-error
iteration6 = zip1.next();
iteration7 = zip1.next();
// @ts-expect-error
iteration8 = zip1.next();

const zip2 = Repeater.zip([Promise.resolve(null), repeater1, repeater2]);
// @ts-expect-error
iteration5 = zip2.next();
// @ts-expect-error
iteration6 = zip2.next();
// @ts-expect-error
iteration7 = zip2.next();
iteration8 = zip2.next();

const latest1 = Repeater.latest([repeater1, repeater2]);
// @ts-expect-error
iteration5 = latest1.next();
// @ts-expect-error
iteration6 = latest1.next();
iteration7 = latest1.next();
// @ts-expect-error
iteration8 = latest1.next();

const latest2 = Repeater.latest([
Promise.resolve(null),
repeater1,
repeater2,
]);
// @ts-expect-error
iteration5 = latest2.next();
// @ts-expect-error
iteration6 = latest2.next();
// @ts-expect-error
iteration7 = latest2.next();
iteration8 = latest2.next();
/* eslint-enable */
}
Loading