Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub release artifact names have changed #1465

Closed
11 tasks done
zeke opened this issue Jan 3, 2024 · 6 comments
Closed
11 tasks done

GitHub release artifact names have changed #1465

zeke opened this issue Jan 3, 2024 · 6 comments
Assignees

Comments

@zeke
Copy link
Member

zeke commented Jan 3, 2024

Newer versions of Cog have assets with lowercase filenames, like cog_darwin_x86_64

But they used to be mixed case, like cog_Darwin_arm64

So now our installation instructions on the README don't work for recent releases, because the output of uname -s on macOS is capitalized Darwin:

sudo curl -o /usr/local/bin/cog -L "https://github.com/replicate/cog/releases/latest/download/cog_$(uname -s)_$(uname -m)"
sudo chmod +x /usr/local/bin/cog

I haven't looked into it yet, but I'm guessing this was an unexpected change from a goreleaser upgrade.

Affected versions:

Last versions before breaking change

To Do

@zeke zeke changed the title GitHub releases artifact names have changed GitHub release artifact names have changed Jan 3, 2024
@zeke
Copy link
Member Author

zeke commented Jan 3, 2024

This was probably the offending change: #1238

Edit: Nope it was #1176

@zeke
Copy link
Member Author

zeke commented Jan 3, 2024

Here's a command for doing a dry run locally and viewing the output names:

goreleaser release --snapshot --skip=publish --clean
cat dist/artifacts.json | jq

(Note this is different from what it was when @mattt last did a dry run: #1176 (comment))

@zeke
Copy link
Member Author

zeke commented Jan 3, 2024

To add fuel to the fire, we also have this new default. prefix which is showing up for arm64 binaries:

default.cog_darwin_arm64
default.cog_linux_arm64

So even if we fix the casing of the uname, the currently documented curl instructions still won't work. 🙄

@zeke
Copy link
Member Author

zeke commented Jan 3, 2024

Seeking guidance here: goreleaser/goreleaser#4513

@zeke
Copy link
Member Author

zeke commented Jan 4, 2024

Partial fix landed here: cf7e41f

@zeke
Copy link
Member Author

zeke commented Jan 4, 2024

Hit this fun little GitHub bug while cleaning up the asset names: https://www.loom.com/share/c2afb266eebf41b0b10be552d29aa1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant