Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize OS name in release artifacts #1467

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

zeke
Copy link
Member

@zeke zeke commented Jan 4, 2024

This is a partial fix for #1465

This PR updates the Goreleaser config to capitalize OS names like Darwin and Linux so they match the output of uname -s, which we've long used for the installation instructions in the README.

@caarlos0 does this look right? I did a dry run locally and I see this:

$ goreleaser release --snapshot --skip=publish --clean              
...
• archives
  • skip archiving                                 binary=cog name=cog_Darwin_arm64
  • skip archiving                                 binary=cog name=cog_Darwin_x86_64
  • skip archiving                                 binary=cog name=cog_Linux_x86_64
  • skip archiving                                 binary=cog name=cog_Linux_arm64

@zeke zeke requested a review from a team January 4, 2024 04:28
Co-authored-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Zeke Sikelianos <[email protected]>
@zeke zeke enabled auto-merge (rebase) January 4, 2024 16:38
@zeke
Copy link
Member Author

zeke commented Jan 4, 2024

Thanks @caarlos0 🙏🏼

@zeke zeke merged commit b96dd52 into main Jan 4, 2024
14 checks passed
@zeke zeke deleted the capitalize-OS-name-in-release-artifacts branch January 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants