Call the web when layers have been pushed #2139
Conversation
* Creates an http client that decorates requests with user agent and authentication. * Adds a monobeam client * Adds a web client * Adds a manifest function to the command * Looks up the manifest from the image and fills in the necessary variables to send to web on version push
Signed-off-by: Will Sackfield <[email protected]>
| } | ||
|
|
||
| func NewMonobaseMatrix(client *http.Client) (*MonobaseMatrix, error) { | ||
| resp, err := client.Get("https://raw.githubusercontent.com/replicate/monobase/refs/heads/main/matrix.json") |
There was a problem hiding this comment.
should we publish this file to a location we control?
There was a problem hiding this comment.
In the future we should, this was a separation of the monobase matrix concern from the fast generator concern so not a new detail from this PR specifically
| if err != nil { | ||
| return nil, err | ||
| } | ||
| trainCode, err := stripCodeFromStub(cogConfig, false) |
There was a problem hiding this comment.
are predictCode and trainCode supposed to be the same value?
There was a problem hiding this comment.
They can be if the train code is in the same file as the predict code, but in general they should be treated as separate values
There was a problem hiding this comment.
oohhhhh I see why I was confused 😅 I was only looking at the function name stripCodeFromStub and didn't read through the implementation with the second positional boolean arg
* And add test verifying these are two separate variables
version push