Send push timings to the server #2152
Merged
+135
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
…ngs-wiring Signed-off-by: Nikhil Sinha <[email protected]>
meatballhat
approved these changes
Feb 15, 2025
go.mod
Outdated
| toolchain go1.23.2 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.6 |
There was a problem hiding this comment.
This looks like maybe your asdf installation isn't happy 🤔 The toolchain should stay in lockstep with what is in .tool-versions.
pkg/docker/push.go
Outdated
Comment on lines
29
to
35
| // Generate 256 bit random hash (4x64 bits) to use as an upload ID | ||
| for i := 0; i < 4; i++ { | ||
| // Ignoring the linter warning about math/rand/v2 not being cryptographically secure | ||
| // because this just needs to be a "unique enough" ID for a cache between when the | ||
| // push starts and ends, which should only be ~a week max. | ||
| imageID = fmt.Sprintf("%s%x", imageID, rand.Int64()) //nolint:gosec | ||
| } |
There was a problem hiding this comment.
- moving this to a function would be nice 😁
- I'm uncomfortable with this being random. Could it be deterministic instead? Isn't this ID assigned by the server side in a later step?
- does
rand.Int64guarantee large enoughint64values for our needs? The docs claim the value will always be a 63 bit int, so I think the answer is "yes", but wanted to call it out.
pkg/docker/push.go
Outdated
Comment on lines
41
to
46
| parts := strings.Split(imageMeta.ID, ":") | ||
| if len(parts) != 2 { | ||
| console.Warn("Image ID was not of the form sha:hash") | ||
| } else { | ||
| imageID = parts[1] | ||
| } |
There was a problem hiding this comment.
nit: Ooh! Use strings.Cut instead!
pkg/docker/push.go
Outdated
Comment on lines
49
to
50
| err = webClient.PostBuildStart(ctx, imageID, buildTime) | ||
| if err != nil { |
There was a problem hiding this comment.
nit: I don't see err being used later, so
Suggested change
| err = webClient.PostBuildStart(ctx, imageID, buildTime) | |
| if err != nil { | |
| if err := webClient.PostBuildStart(ctx, imageID, buildTime); err != nil { |
pkg/web/client.go
Outdated
| } | ||
|
|
||
| url := webBaseURL() | ||
| url.Path = strings.Join([]string{"", "api", "models", "build-start"}, "/") |
There was a problem hiding this comment.
nit: Given there's no variable data in this string, I think it should be a const instead.
pkg/web/client.go
Outdated
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusCreated { | ||
| return errors.New("Bad response from new version endpoint: " + strconv.Itoa(resp.StatusCode)) |
There was a problem hiding this comment.
nit: it's not a huge deal in this context since the process is not long-lived, but errors.New should generally not be used like this. Instead, define a module-level var of the base error and then use error wrapping to include the variable bit.
…ngs-wiring Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
Signed-off-by: Nikhil Sinha <[email protected]>
…ngs-wiring Signed-off-by: Nikhil Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to know about how long it takes to build and push images. If we are introducing something called "fast push", we should probably know if it is actually faster or not than the same thing through the standard push flow.
Test Plan
Do a push with the fast push flow and the standard push flow and see if they still work