decouple init and start
#4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhchavez
approved these changes
May 3, 2024
| @@ -3,13 +3,16 @@ | |||
|
|
|||
| /* auto-generated by NAPI-RS */ | |||
|
|
|||
| export interface Pid { | |||
| pid: number | |||
| } | |||
| export interface Size { | |||
| cols: number | |||
| rows: number | |||
| } | |||
| export class Pty { | |||
There was a problem hiding this comment.
does napi-rs preserve comments? it would be neat to have a little warning in the docstring telling folks to always start reading from the FD before calling start to avoid surprises.
There was a problem hiding this comment.
hm, this file is auto-generated, not sure if we can inject comments into it
Merged
lhchavez
added a commit
that referenced
this pull request
May 3, 2024
#4 added a lot of good CI improvements. Let's land them ASAP! This change takes #4 and only keeps the changes needed to fix CI and local Linux development. --------- Co-authored-by: Szymon Kaliski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently starting the child process is tied to the
Ptyinitialization, which can lead to a race condition like:Ptywhich evaluatesecho 'hello'-- this returnsfdand starts the child process immediatelymsfd-- it is already invalid since the child exited!This PR decouples creating the
Pty/fdfrom actually starting the child -- the newcan start the process at an arbitrary later point in timetest shows how that works.This PR also pins the CI bun version to
1.0.26which is what theflake.nixis pinned to. I'll follow up with updatingbunversion in another PR.