Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Avoid running poetry at all for env detection in a repl #230

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

blast-hardcheese
Copy link
Collaborator

Why

Terminate early if we're running inside a repl.

This will suppress the following poetry commands from showing up in the Packager pane.

What changed

Switch env detection based on whether $REPL_HOME is defined

Test plan

Clear the poetry.lock in order to re-trigger a lock on Run, verify that the poetry env list --full-path command does not show up in the packager pane every time on Run, as it alarms users.

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner February 7, 2024 21:03
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team February 7, 2024 21:03
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) February 7, 2024 21:04
@blast-hardcheese blast-hardcheese merged commit 2682313 into main Feb 7, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/avoid-poetry-env-logging branch February 7, 2024 21:14
@blast-hardcheese blast-hardcheese added chore bug Something isn't working and removed chore labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants