Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uv] use torch cpu integration instead of env var #323

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

rmehri01
Copy link
Contributor

@rmehri01 rmehri01 commented Dec 31, 2024

Why

What changed

  • Check to see if torch is in the added packages or already in the spec file and if so, idempotently add the torch cpu override to pyproject.toml using toml-editor

Test plan

  • Running locally as well as on replit should work now:
image

@rmehri01 rmehri01 requested a review from a team as a code owner December 31, 2024 19:37
@rmehri01 rmehri01 requested review from vlinkz and removed request for a team December 31, 2024 19:37
@rmehri01 rmehri01 force-pushed the rmehri01/torch-cpu-override branch from de569af to ef79c0e Compare December 31, 2024 19:41
Copy link
Collaborator

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there! You should also be able to test this in a repl, now that the latest toml-editor has rolled out 💪

@rmehri01 rmehri01 force-pushed the rmehri01/torch-cpu-override branch from 945210c to 82efdd9 Compare January 4, 2025 02:44
@rmehri01 rmehri01 force-pushed the rmehri01/torch-cpu-override branch 3 times, most recently from e569d41 to 14902cf Compare January 6, 2025 23:28
@rmehri01 rmehri01 force-pushed the rmehri01/torch-cpu-override branch from 14902cf to 2166966 Compare January 8, 2025 02:11
Copy link
Collaborator

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@rmehri01 rmehri01 merged commit 81b5361 into main Jan 8, 2025
5 checks passed
@rmehri01 rmehri01 deleted the rmehri01/torch-cpu-override branch January 8, 2025 22:22
@rmehri01 rmehri01 added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants