Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document workaround for branch protection settings #151

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

octonato
Copy link
Contributor

@octonato octonato commented Oct 17, 2019

Relates to #150. It's not a fix, but at least document how to workaround it.


View rendered README.md

@travi
Copy link
Member

travi commented Oct 18, 2019

thanks. this will be very helpful until we can get #150 resolved.

@travi travi merged commit aaa6081 into repository-settings:master Oct 18, 2019
@travi
Copy link
Member

travi commented Oct 18, 2019

@renatocaval i'm looking at this a little more closely and thinking about inlining these notes into the larger example in order to be more consistent with existing notes. in looking, i notice that there are already notes about these details being "Required". i could simply include a note for each of those to set to null if not wanting to set them, but i'm wondering if they would be noticed. do you think they would have clarified the issue that you were having, or would you have overlooked the note there?

@octonato
Copy link
Contributor Author

Hmm, indeed. Maybe we should have just a short heads-up.

I find it easier to miss the instructions if it's in the form of comments in the config file. As you can see, I didn't read them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants