Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Emails Politiker*innen-Fragebogen #500

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

lucianak
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2023 8:36am
republik-love ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2023 8:36am

const from_email = DEFAULT_MAIL_FROM_ADDRESS
const from_name = DEFAULT_MAIL_FROM_NAME

const requiredColumns = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da wären dann am Ende nur die Columns drin, die wir für die Email-Templates brauchen (und im CSV dann auch)

@lucianak lucianak requested a review from fuenkchen June 20, 2023 14:00
Copy link
Contributor

@fuenkchen fuenkchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename the email templates as well? Atm they have the prefix access_recipient which could lead to confusion because they are not access grant related.

Afaik we haven't decided yet if this should be merged into main. If so there should be some documentation (e.g. on how csv file should look like). If not this is not necessary (but could be done as well, in case we want to reuse it again with the code from this PR).

@lucianak
Copy link
Contributor Author

lucianak commented Jun 26, 2023

@fuenkchen tbh I don't think we can reuse this code, it's not very generic. I'd say to not merge into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants