-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Emails Politiker*innen-Fragebogen #500
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
const from_email = DEFAULT_MAIL_FROM_ADDRESS | ||
const from_name = DEFAULT_MAIL_FROM_NAME | ||
|
||
const requiredColumns = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Da wären dann am Ende nur die Columns drin, die wir für die Email-Templates brauchen (und im CSV dann auch)
...ges/backend-modules/mail/script/sendMailsToSegment/politicianQuestionnaireMailing_06-2023.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the email templates as well? Atm they have the prefix access_recipient
which could lead to confusion because they are not access grant related.
Afaik we haven't decided yet if this should be merged into main. If so there should be some documentation (e.g. on how csv file should look like). If not this is not necessary (but could be done as well, in case we want to reuse it again with the code from this PR).
packages/backend-modules/mail/templates/access_recipient_questionnaire_politician.txt
Outdated
Show resolved
Hide resolved
packages/backend-modules/mail/templates/access_recipient_questionnaire_politician.html
Outdated
Show resolved
Hide resolved
@fuenkchen tbh I don't think we can reuse this code, it's not very generic. I'd say to not merge into main |
No description provided.