Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.29 #78

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Update to egui 0.29 #78

merged 4 commits into from
Sep 26, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 26, 2024

emilk added a commit to rerun-io/rerun that referenced this pull request Sep 2, 2024
### What
* Tracks egui `master` branch
* Tracks rerun-io/egui_tiles#78

~This changes the interface between HTML/JS and WASM from passing a
canvas id, to passing the canvas element directly
(emilk/egui#4780). This means the preview of
this PR is broken, and merging this PR will likely break it for all
subsequent PRs. @jprochazk do you have a good idea how we can fix this?~

### TODO
* [x] The `re_renderer` example needs a winit update
* [x] Fix uses of deprecated functions.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested `pixi run rerun-web`
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7218?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7218?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7218)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk emilk added the include in changelog Include this in CHANGELOG.md label Sep 26, 2024
@emilk emilk changed the title Tracking: Update to next egui version Update to egui 0.29 Sep 26, 2024
@emilk emilk marked this pull request as ready for review September 26, 2024 13:48
emilk added a commit to emilk/egui_plot that referenced this pull request Sep 26, 2024
Getting ready for egui 0.29

See also:
* rerun-io/egui_tiles#78
@emilk emilk merged commit 98c6737 into main Sep 26, 2024
10 checks passed
@emilk emilk deleted the emilk/egui-0.29 branch September 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog Include this in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant