Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
emilk committed Sep 29, 2024
1 parent d73a5fa commit 3a9e692
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions crates/store/re_chunk/src/chunk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ impl PartialEq for Chunk {
impl Chunk {
/// Returns a version of us with a new id
#[must_use]
#[inline]
pub fn with_id(mut self, id: ChunkId) -> Self {
self.id = id;
self
Expand Down
2 changes: 1 addition & 1 deletion crates/viewer/re_ui/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ impl UICommand {
Self::CloseAllRecordings => None,

Self::Undo => Some(cmd(Key::Z)),
Self::Redo => Some(cmd_shift(Key::Z)), // TODO: cmd-y?
Self::Redo => Some(cmd_shift(Key::Z)),

#[cfg(all(not(target_arch = "wasm32"), target_os = "windows"))]
Self::Quit => Some(KeyboardShortcut::new(Modifiers::ALT, Key::F4)),
Expand Down
1 change: 0 additions & 1 deletion crates/viewer/re_viewer/src/app_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ impl AppState {
/// If `inspect_blueprint_timeline` is enabled, we use the time selection from the
/// blueprint `time_ctrl`. Otherwise, we use a latest query from the blueprint timeline.
pub fn blueprint_query_for_viewer(&mut self, blueprint: &EntityDb) -> LatestAtQuery {
// TODO: sync self.blueprint_cfg.time_ctrl and blueprint_undo_state
if self.app_options.inspect_blueprint_timeline {
self.blueprint_cfg.time_ctrl.read().current_query().clone()
} else {
Expand Down
4 changes: 2 additions & 2 deletions crates/viewer/re_viewer/src/ui/rerun_menu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ impl App {

ui.add_space(SPACING);

UICommand::Undo.menu_button_ui(ui, &self.command_sender); // TODO: only enabled if there is something to undo/redo
UICommand::Redo.menu_button_ui(ui, &self.command_sender); // TODO: only enabled if there is something to undo/redo
UICommand::Undo.menu_button_ui(ui, &self.command_sender); // TODO(emilk): only enabled if there is something to undo
UICommand::Redo.menu_button_ui(ui, &self.command_sender); // TODO(emilk): only enabled if there is something to redo

UICommand::ToggleCommandPalette.menu_button_ui(ui, &self.command_sender);

Expand Down

0 comments on commit 3a9e692

Please sign in to comment.