-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the GeoLineStrings
archetype and support it in the map view
#7968
Open
abey79
wants to merge
25
commits into
main
Choose a base branch
from
antoine/linestrip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,340
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
do-not-merge
Do not merge this PR
exclude from changelog
PRs with this won't show up in CHANGELOG.md
feat-map-view
Everything related to the map view
labels
Nov 1, 2024
Deployed docs
|
abey79
force-pushed
the
antoine/linestrip
branch
from
November 1, 2024 10:58
439a8f7
to
a0020fe
Compare
abey79
force-pushed
the
antoine/linestrip
branch
5 times, most recently
from
November 2, 2024 17:44
67ceb7a
to
2324aea
Compare
emilk
requested changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel very uneasy with an interface that doesn't explicitly spell out the order of latitude and longitude for all our map primitives, consider this has been the source of bugs for so many years for so many people
crates/store/re_types/definitions/rerun/components/geo_line_string.fbs
Outdated
Show resolved
Hide resolved
An error occurred while trying to automatically change base from
andreas/re_renderer-in-map
to
main
November 4, 2024 11:47
abey79
force-pushed
the
antoine/linestrip
branch
from
November 4, 2024 14:11
5a29c80
to
af9756c
Compare
…the custom constructors
emilk
approved these changes
Nov 4, 2024
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
feat-map-view
Everything related to the map view
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
☝🏻 title
GeoLineStrings
archetype, using a newGeoLineString
component$origin = /
single view will be spawned whenever a singleGeoXXX
entity exists anywhere.GeoPoints
GeoLineStrings
(but not screenshot, blocked on Add round join to line strips #829)rerun.hpp
LineStrip2D
edit ui forGeoLineString
GeoPoints
GeoLineStrings
Switzerland boundaries according to a couple of AIs and an official source:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.