Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the GeoLineStrings archetype and support it in the map view #7968

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 1, 2024

What

☝🏻 title

  • New GeoLineStrings archetype, using a new GeoLineString component
  • Support it in the map view
  • Fix heuristics for the map view: now a $origin = / single view will be spawned whenever a single GeoXXX entity exists anywhere.
  • Snippets and screenshot for GeoPoints
  • Snippet for GeoLineStrings (but not screenshot, blocked on Add round join to line strips #829)
  • Added some types to rerun.hpp
  • Fixed/copy/pasted LineStrip2D edit ui for GeoLineString
  • Add python unit tests for GeoPoints
  • Add python unit tests for GeoLineStrings

Switzerland boundaries according to a couple of AIs and an official source:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Deployed docs

Commit Link
50b4991 https://landing-5is26iekl-rerun.vercel.app/docs

@abey79 abey79 mentioned this pull request Nov 1, 2024
28 tasks
@abey79 abey79 marked this pull request as ready for review November 1, 2024 18:24
@abey79 abey79 force-pushed the antoine/linestrip branch 5 times, most recently from 67ceb7a to 2324aea Compare November 2, 2024 17:44
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel very uneasy with an interface that doesn't explicitly spell out the order of latitude and longitude for all our map primitives, consider this has been the source of bugs for so many years for so many people

crates/viewer/re_component_ui/src/geo_line_string.rs Outdated Show resolved Hide resolved
crates/viewer/re_component_ui/src/geo_line_string.rs Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_line_string_simple.py Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_line_string_simple.cpp Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.cpp Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.py Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/geo_point_simple.rs Outdated Show resolved Hide resolved
Base automatically changed from andreas/re_renderer-in-map to main November 4, 2024 11:47
An error occurred while trying to automatically change base from andreas/re_renderer-in-map to main November 4, 2024 11:47
@abey79 abey79 removed the do-not-merge Do not merge this PR label Nov 4, 2024
rerun_cpp/src/rerun/archetypes/geo_points_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/components/geo_line_string_ext.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants