Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage TransportChunk for registration metadata instead of carrying arrow data + schema tuple arround #7985

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

zehiko
Copy link
Contributor

@zehiko zehiko commented Nov 4, 2024

What

As the title says, it's much more convenient and simpler to use TransportChunk for metadata as well, at least until we migrate to arrow.

Tiny bonus change - add id to register metadata response as its consistent with other responses and again convenient to use.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@zehiko zehiko added exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API labels Nov 4, 2024
@zehiko zehiko requested review from emilk and jleibs November 4, 2024 10:49
@zehiko zehiko self-assigned this Nov 4, 2024
Base automatically changed from zehiko/register-single to main November 4, 2024 15:25
@zehiko zehiko merged commit 85d152a into main Nov 4, 2024
36 checks passed
@zehiko zehiko deleted the zehiko/tc-for-metadata branch November 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants