Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration support to python remote API #7995

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 4, 2024

What

Example:

import rerun as rr
import pyarrow as pa

rr.init("rerun_example_reds")
rr.save("/tmp/test.rrd")
rr.log("test", rr.TextLog("Hello, world!"))

conn = rr.remote.connect("http://0.0.0.0:51234")

resp = conn.register(
    "file:///tmp/test.rrd",
    {
        "my_col": pa.array(["c"]),
    },
)
print(f"Registered recording with id: {resp}")

Verified in the catalog:

┌─────────────────────────────────┬─────────────┬──────────────────────┬────────────────┬────────┐
│ id                              ┆ description ┆ storage_url          ┆ recording_type ┆ my_col │
│ ---                             ┆ ---         ┆ ---                  ┆ ---            ┆ ---    │
│ str                             ┆ str         ┆ str                  ┆ cat            ┆ str    │
╞═════════════════════════════════╪═════════════╪══════════════════════╪════════════════╪════════╡
│ a82d7976-f9a5-49e2-825e-ab2771… ┆             ┆ file:///tmp/test.rrd ┆ rrd            ┆ c      │
└─────────────────────────────────┴─────────────┴──────────────────────┴────────────────┴────────┘

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API do-not-merge Do not merge this PR 🐍 Python API Python logging API labels Nov 4, 2024
@jleibs jleibs marked this pull request as ready for review November 4, 2024 20:37
@jleibs jleibs changed the base branch from main to jleibs/py_remote_api November 4, 2024 20:37
@jleibs jleibs changed the title Jleibs/py remote register Add registration support to python remote API Nov 4, 2024
.transpose()?;

let request = RegisterRecordingRequest {
// TODO(jleibs): Description should really just be in the metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're suggesting that description is basically and optional metadata field, right? if so, that indeed makes sense to me.

Base automatically changed from jleibs/py_remote_api to main November 5, 2024 12:12
@jleibs jleibs removed the do-not-merge Do not merge this PR label Nov 5, 2024
@jleibs jleibs merged commit fb5a4c6 into main Nov 5, 2024
19 of 22 checks passed
@jleibs jleibs deleted the jleibs/py_remote_register branch November 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants