Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryHandle: automatically scheduled wake-up call #8017

Merged
merged 6 commits into from
Nov 6, 2024
Merged

QueryHandle: automatically scheduled wake-up call #8017

merged 6 commits into from
Nov 6, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 6, 2024 •
edited by github-actions bot
Loading

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API dataplatform Rerun Data Platform integration labels Nov 6, 2024
zehiko
zehiko approved these changes Nov 6, 2024
View reviewed changes
crates/store/re_dataframe/src/query.rs
//
// We'll use this to build a noop async context, so that we can poll our promises
// manually.
const RAW_WAKER_NOOP: std::task::RawWaker = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's some voodoo!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup... 😞

@teh-cmc teh-cmc merged commit 6b3d7fd into main Nov 6, 2024
36 checks passed
@teh-cmc teh-cmc deleted the cmc/query_handle_awaken branch November 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryHandle::next_row_async never schedules a waking task
2 participants
@teh-cmc @zehiko